Open
Conversation
ckousik
reviewed
Dec 22, 2022
|
|
||
| const RELAY_STARTUP_TIMEOUT = Number(process.env.RELAY_STARTUP_TIMEOUT || 30000) | ||
|
|
||
| const run = async (configPath, identityPath) => { |
Contributor
There was a problem hiding this comment.
could we make both configPath and identityPath optional?
Author
There was a problem hiding this comment.
Certainly. Is this a reasonable default (pulled from ipfs test utils)?
{
"RelayV1": {
"Enabled": false
},
"RelayV2": {
"Enabled": true
},
"Network": {
"ListenAddrs": ["/ip4/127.0.0.1/tcp/24222/ws"],
"AnnounceAddrs": ["/ip4/127.0.0.1/tcp/24222/ws"]
},
"Daemon": {
"PprofPort": -1
}
}
Author
There was a problem hiding this comment.
I implemented the above, let me know if you'd like anything changed @ckousik.
Author
|
@ckousik good to merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
execadirectly to the repository and export functions to configure and run the relay daemon directly from the repository instead of writing glue code injs-libp2porinterop.runexport that runs the relay daemon